Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(netlify): emit server.js to leverage native esm #401

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 9, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Emit server.js CJS wrapper for netlify output to avoid needing a rebuilt from netlify and leverage native ESM.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #401 (425b0c2) into main (d72f223) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head 425b0c2 differs from pull request most recent head c9186a7. Consider uploading reports for the commit c9186a7 to get more accurate results

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   56.39%   56.26%   -0.14%     
==========================================
  Files          54       54              
  Lines        3454     3464      +10     
  Branches      369      367       -2     
==========================================
+ Hits         1948     1949       +1     
- Misses       1151     1162      +11     
+ Partials      355      353       -2     
Impacted Files Coverage Ξ”
src/presets/netlify.ts 25.30% <0.00%> (-2.87%) ⬇️
src/prerender.ts 67.34% <0.00%> (+0.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 8304ae2 into main Aug 9, 2022
@pi0 pi0 deleted the feat/netlify-cjs branch August 9, 2022 19:01
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant