Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static): use correct format for last modified #1017

Merged
merged 3 commits into from
Mar 3, 2023
Merged

fix(static): use correct format for last modified #1017

merged 3 commits into from
Mar 3, 2023

Conversation

janjhnsn
Copy link
Contributor

@janjhnsn janjhnsn commented Mar 3, 2023

πŸ”— Linked issue

#1016

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Changed Last-Modified format to be correct (UTC) and not ISO as currecntly. Resolves #1016

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: use correct format for last modified fix(static): use correct format for last modified Mar 3, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1017 (7db2bdf) into main (8f9c3e2) will not change coverage.
The diff coverage is n/a.

❗ Current head 7db2bdf differs from pull request most recent head 26ac8e6. Consider uploading reports for the commit 26ac8e6 to get more accurate results

@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   67.69%   67.69%           
=======================================
  Files          60       60           
  Lines        6167     6167           
  Branches      692      692           
=======================================
  Hits         4175     4175           
  Misses       1982     1982           
  Partials       10       10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0
Copy link
Member

pi0 commented Mar 3, 2023

Can you please rebase your PR and fix lint issues? (i don't have push access to your fork)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last-Modified date format is wrong
2 participants