Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg): add http-proxy types to deps #1213

Merged
merged 1 commit into from
May 8, 2023
Merged

fix(pkg): add http-proxy types to deps #1213

merged 1 commit into from
May 8, 2023

Conversation

danielroe
Copy link
Collaborator

πŸ”— Linked issue

nuxt/nuxt#20698

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I think it makes sense to include the type dependency on this one as otherwise users don't get types for it when using nitro options.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label May 6, 2023
@danielroe danielroe requested a review from pi0 May 6, 2023 08:00
@danielroe danielroe self-assigned this May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #1213 (57f12de) into main (a9781ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1213   +/-   ##
=======================================
  Coverage   77.20%   77.20%           
=======================================
  Files          67       67           
  Lines        6655     6655           
  Branches      681      681           
=======================================
  Hits         5138     5138           
  Misses       1516     1516           
  Partials        1        1           

@pi0 pi0 changed the title chore: add http-proxy types to deps fix(pkg): add http-proxy types to deps May 8, 2023
@pi0 pi0 merged commit 2ef9608 into main May 8, 2023
@pi0 pi0 deleted the chore/type-dep branch May 8, 2023 09:13
pi0 pushed a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants