Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customising generated tsConfig #1266

Merged
merged 1 commit into from
Jun 16, 2023
Merged

feat: allow customising generated tsConfig #1266

merged 1 commit into from
Jun 16, 2023

Conversation

danielroe
Copy link
Collaborator

πŸ”— Linked issue

nuxt/nuxt#21074

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Users or consuming frameworks might need to customise the generated tsConfig - this makes that possible via nitro options.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label May 26, 2023
@danielroe danielroe requested a review from pi0 May 26, 2023 17:00
@danielroe danielroe self-assigned this May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1266 (86d61ab) into main (2ad4389) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
+ Coverage   76.83%   76.90%   +0.06%     
==========================================
  Files          68       68              
  Lines        6829     6832       +3     
  Branches      692      693       +1     
==========================================
+ Hits         5247     5254       +7     
+ Misses       1580     1577       -3     
+ Partials        2        1       -1     
Impacted Files Coverage Ξ”
src/build.ts 85.21% <100.00%> (ΓΈ)
src/options.ts 94.33% <100.00%> (+0.01%) ⬆️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

@pi0
Copy link
Member

pi0 commented Jun 16, 2023

(CI on main is failing so edge will be delivered in a bit)

@pi0 pi0 merged commit 126e085 into main Jun 16, 2023
@pi0 pi0 deleted the feat/custom-tsconfig branch June 16, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants