fix(externals): trace externals with their commonjs / esm status #1562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #1558 (comment)
β Type of change
π Description
Reproduction: https://stackblitz.com/edit/github-kkcfd3?file=package.json
vercel/nft smartly applies
import
ORrequire
conditions based on the parent file. By overriding (giving both import and require conditions) we were allowing nft to resolve as ESM even for CommonJS modules.π Checklist