Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stormkit): properly send buffer responses #1616

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 22, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Stormkit requires buffer responses to be stringified AND be sent via buffer field instead of body.

This PR also updates types to match the underlying struct and normalized header.

Happy deployment: https://nuxt-image-remote-ipx.stormkit.dev/

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1616 (5ee3292) into main (6cb72e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1616   +/-   ##
=======================================
  Coverage   77.79%   77.79%           
=======================================
  Files          76       76           
  Lines        7835     7835           
  Branches      804      804           
=======================================
  Hits         6095     6095           
  Misses       1738     1738           
  Partials        2        2           

@pi0 pi0 merged commit b0a45c7 into main Aug 22, 2023
8 checks passed
@pi0 pi0 deleted the fix/stormkit-buffer branch August 22, 2023 10:12
@pi0 pi0 mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant