Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add parent node_modules of nitro to modules dir for pnpm compat #1618

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 22, 2023

πŸ”— Linked issue

resolves nitrojs/nitro-deploys#83

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Nitro installed in an external repository and with pnpm, adds rootDir/node_modules + rootDir/node_modules/.pnpm/nitropack-edge@2.6.0-28209634.345d0cc/node_modules/nitropack-edge/node_modules to the search path because of pnpm behavior and this causes the nitro direct runtime dependencies to fail to resolve.

This PR fixes it by also adding outer node_modules dir available for search and removed old dedup logic since is no longer necessary.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1618 (9dca8e3) into main (8d7e660) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
- Coverage   77.79%   77.69%   -0.10%     
==========================================
  Files          76       76              
  Lines        7835     7823      -12     
  Branches      804      799       -5     
==========================================
- Hits         6095     6078      -17     
- Misses       1738     1742       +4     
- Partials        2        3       +1     
Files Changed Coverage Ξ”
src/options.ts 96.97% <100.00%> (+0.32%) ⬆️

... and 2 files with indirect coverage changes

@pi0 pi0 merged commit 347a88b into main Aug 22, 2023
8 checks passed
@pi0 pi0 deleted the fix/modules-dir branch August 22, 2023 19:02
@pi0 pi0 mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find package 'node-fetch-native' error with node, and externals enabled repos
1 participant