Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda, netlify): add isBase64Encoded response field #1645

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

Azcray
Copy link
Contributor

@Azcray Azcray commented Aug 26, 2023

πŸ”— Linked issue

#1274 PR
#22832 Nuxt
#852

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I added the isBase64Encoded option to allow Lambda to understand that the request is a base64 encoded document.

I complete the PR #1274 to solve this problem.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Azcray
Copy link
Contributor Author

Azcray commented Aug 26, 2023

I tested with serverless-offline and it works great!

@pi0 pi0 changed the title fix(aws-lambda,netlify): Add isBase64Encoded for encode binary responses fix(aws-lambda, netlify): add isBase64Encoded response field Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #1645 (7ae9766) into main (61144e5) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 7ae9766 differs from pull request most recent head 9deb910. Consider uploading reports for the commit 9deb910 to get more accurate results

@@           Coverage Diff           @@
##             main    #1645   +/-   ##
=======================================
  Coverage   77.76%   77.76%           
=======================================
  Files          76       76           
  Lines        7824     7824           
  Branches      803      803           
=======================================
  Hits         6084     6084           
  Misses       1738     1738           
  Partials        2        2           

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit 2fea3d0 into nitrojs:main Aug 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants