Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix code comments #1673

Merged
merged 6 commits into from
Sep 1, 2023
Merged

chore: fix code comments #1673

merged 6 commits into from
Sep 1, 2023

Conversation

markthree
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The notes seem to have been written backwards.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title chore(cli/commands/dev): adjustment notes chore: fix code comments Aug 30, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1673 (b9178a5) into main (f126cbf) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1673      +/-   ##
==========================================
- Coverage   77.78%   77.67%   -0.11%     
==========================================
  Files          76       76              
  Lines        7827     7827              
  Branches      804      800       -4     
==========================================
- Hits         6088     6080       -8     
- Misses       1737     1744       +7     
- Partials        2        3       +1     

see 2 files with indirect coverage changes

src/cli/commands/dev.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit 3315c99 into nitrojs:main Sep 1, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants