Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): allow overriding integrity #1791

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix(cache): allow overriding integrity #1791

merged 2 commits into from
Oct 5, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 5, 2023

πŸ”— Linked issue

(context: occurred this limit while working on ungh.cc cache)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Cache integrity should be overirdable. Previously we were always making a hash from function implementation making it impossible to change.

Note: This is slight breaking behavior but only effect is that old caches with custom integrity will be invalidated to respect custom one.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 6c51546 into main Oct 5, 2023
5 of 6 checks passed
@pi0 pi0 deleted the fix/cache-integrity branch October 5, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant