Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): write swr and update errors to console #1794

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 5, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

After the introduction of captureError API and integrating it with cache API, we removed explicit console.error logs when an issue happens for updating cache storage or evaluating SWR handler in the background.

This PR adds them back. As a future improvement, we might smartly show errors only if there is no error handler but it might also cause DX issues if all handlers are system handlers. So something to explore more later.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(cache): output silent swr/write errors fix(cache): write swr and update errors to console Oct 5, 2023
@pi0 pi0 merged commit 0599ace into main Oct 5, 2023
6 checks passed
@pi0 pi0 deleted the fix/silent-cache-errors branch October 5, 2023 16:09
@pi0 pi0 mentioned this pull request Oct 5, 2023
@pi0 pi0 mentioned this pull request Nov 19, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant