Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(routing): update request filtering to match the type of getRequestURL #1977

Merged
merged 1 commit into from
Dec 1, 2023
Merged

docs(routing): update request filtering to match the type of getRequestURL #1977

merged 1 commit into from
Dec 1, 2023

Conversation

GalacticHypernova
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Due to getRequestURL returning a URL, the example of request filtering might be misleading for newcomers. This PR fixes the documentation to comply with its return type.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio Nuxt Studio
Copy link
Contributor

nuxt-studio bot commented Dec 1, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio ↗︎ View Live Preview 27b3c3a

pi0
pi0 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 changed the title docs: update request filtering to match the type of getRequestURL docs(routing): update request filtering to match the type of getRequestURL Dec 1, 2023
@pi0 pi0 merged commit 06323b7 into nitrojs:main Dec 1, 2023
4 checks passed
@GalacticHypernova GalacticHypernova deleted the patch-1 branch December 1, 2023 10:32
@GalacticHypernova
Copy link
Contributor Author

Glad to help!

@pi0 pi0 mentioned this pull request Feb 27, 2024
Closed
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GalacticHypernova @pi0