Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support binary server assets #2107

Merged
merged 6 commits into from
Jan 22, 2024
Merged

feat: support binary server assets #2107

merged 6 commits into from
Jan 22, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 22, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We initially introduced server assets to allow serving small nonbinary data such as HTML templates, JSON, and Markdown files.

@atinux was working on a POC that encountered the limitation of needing to bundle binary data.

This PR allows this by converting non-recognized extensions to base64 encoded string and restoring to ArrayBuffer at runtime.

This is a quick way to support the feature however for platforms that natively support filesystem access, not performant at all and later we shall improve it. So unless you have to, don't use it!

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 60eb9f6 into main Jan 22, 2024
5 checks passed
@pi0 pi0 deleted the feat/raw-server-assets branch January 22, 2024 22:49
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant