Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lagon #2203

Merged
merged 1 commit into from
Mar 1, 2024
Merged

chore: remove lagon #2203

merged 1 commit into from
Mar 1, 2024

Conversation

maximepvrt
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@maximepvrt
Copy link
Contributor Author

maximepvrt commented Mar 1, 2024

@pi0 I haven't deleted the page to https://nitro.unjs.io/deploy/providers/lagon (which doesn't work anyway) yet. Should it be kept or redirected to https://nitro.unjs.io/deploy

@pi0
Copy link
Member

pi0 commented Mar 1, 2024

Thanks for the PR but why? (this change is removing lagon from code. i know platform is EOL, but lagon is an example that can happen in the future. as long as it is alive, removing from code in a non major version means we break even 1 current user of it in private alpha. it is not big deal, also not a big deal to keep the code until it is completely unrelavant)

@maximepvrt
Copy link
Contributor Author

This means Lagon will be ending services. All projects on Lagon should be 100% compatible with Vercel Functions. If you are having trouble migrating, please do not hesitate to reach out. If you had access to Lagon Alpha, your projects will be offline on 03/01/2024.

Lagon mail received Dec 14 2023, 4:24 p.m.

I just thought it was an easy and helpful contribution to clean up

@pi0
Copy link
Member

pi0 commented Mar 1, 2024

Thanks for clearify. I imagined it would be alive for few months more in alpha if completely out of service we can remove it πŸ‘πŸΌ

@pi0 pi0 merged commit 18f2f33 into nitrojs:main Mar 1, 2024
@maximepvrt
Copy link
Contributor Author

@pi0 and I delete this page? https://github.com/unjs/nitro/blob/main/docs/2.deploy/20.providers/lagon.md

@pi0 I haven't deleted the page to https://nitro.unjs.io/deploy/providers/lagon (which doesn't work anyway) yet. Should it be kept or redirected to https://nitro.unjs.io/deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants