Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deploy): add link to zero config providers #2206

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

shinGangan
Copy link
Contributor

@shinGangan shinGangan commented Mar 2, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Only the Cloudflare page did not have a link to the Zero-Config Providers.

( Confirmed that AWS Amplify, Azure, Netlify, Vercel and Zeabur are fine. πŸ™† )

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@shinGangan shinGangan changed the title docs(cloudflare): add link to zero configuration page docs(cloudflare): add link to 'Zero-Config Providers' section Mar 2, 2024
@shinGangan shinGangan changed the title docs(cloudflare): add link to 'Zero-Config Providers' section docs(cloudflare): add links to 'Zero-Config Providers' section Mar 2, 2024
@shinGangan
Copy link
Contributor Author

Hi @pi0 .

The link to the docs was broken, so I added it.
Please review it when you have a time, as it is low priority due to the docs. πŸ™

@pi0 pi0 changed the title docs(cloudflare): add links to 'Zero-Config Providers' section docs(deploy): add link to zero config providers Mar 3, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I might remove links (from all) in the future because the definition of zero config is becoming more ambiguous nowadays. But fair enough lets keep things consistent πŸ‘πŸΌ

@pi0 pi0 merged commit 7f8f653 into nitrojs:main Mar 3, 2024
@shinGangan shinGangan deleted the docs/fix-cloudflare-pages branch March 4, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants