Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(externals): check explicit inline rules on resolved id #2288

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 21, 2024

πŸ”— Linked issue

reproduction with shiki/wasm: https://stackblitz.com/edit/unjs-nitro-starter-4aetky?file=server%2Froutes%2Findex.ts

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Externals plugin used to only check against original id. If a resolved id is matching explicit inline patterns, it was not respected.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 882f0a9 into main Mar 21, 2024
4 of 5 checks passed
@pi0 pi0 deleted the fix/externals-inline branch March 21, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants