Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify): match ISR route rules when path has a query string #2440

Merged
merged 3 commits into from
May 16, 2024

Conversation

serhalp
Copy link
Contributor

@serhalp serhalp commented May 13, 2024

πŸ”— Linked issue

Fixes #2431.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

See the linked issue. This was because getRouteRulesForPath expects a bare path with no query string, but this wasn't obvious or documented. I added a regression test and an inline doc comment.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Rigo-m
Copy link
Contributor

Rigo-m commented May 13, 2024

That makes sense on why it wasn't working.
Thanks @serhalp!
Care to add also the quickfix present in #2425?
It makes sense to let @pi0 check only this PR and I can happily sunset the other to speed things up

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix(netlify-v2): match ISR route rules when path has a query string fix(netlify): match ISR route rules when path has a query string May 16, 2024
@pi0 pi0 merged commit 6adc84c into nitrojs:main May 16, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Jun 13, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Netlify-Vary header in netlify v2 preset
3 participants