Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): correctly watch custom apiDir and routesDir #2502

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

94726
Copy link
Contributor

@94726 94726 commented Jun 7, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Nitro supports customizing apiDir and routesDir, but continues to watch the creation/deletion of files only in the default "api" and "routes" folders.
This PR simply configures the watcher to use the configured ones if provided πŸ™‚

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@94726 94726 changed the title fix: watch custom apiDir and routesDir fix: missing watch of custom apiDir and routesDir Jun 7, 2024
@pi0 pi0 changed the title fix: missing watch of custom apiDir and routesDir fix(build): correctly watch custom apiDir and routesDir Jun 8, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit c9a7afc into nitrojs:main Jun 8, 2024
@pi0 pi0 mentioned this pull request Jun 13, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants