Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(playground): does not overwrite tsconfig.paths #2507

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

Barbapapazes
Copy link
Member

@Barbapapazes Barbapapazes commented Jun 10, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hello πŸ‘‹,

This PR rework the TSConfig in the playground to not overwrite paths from the generated tsconfig file.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title chore(playground): does not overwrite generate tsconfig paths chore(playground): does not overwrite tsconfig.paths Jun 12, 2024
@pi0
Copy link
Member

pi0 commented Jun 12, 2024

Thanks for noticing it. We should not need paths hack

@pi0 pi0 merged commit 8928c3a into nitrojs:main Jun 12, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants