Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): extract links from explicit html routes #2517

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

danielroe
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Discovered while triaging nuxt/nuxt#27490 (which is a bug in Nuxt). We are not crawling paths that are prerendered with an explicit .html suffix.

It feels like this might be an oversight, and we could benefit from this in Nuxt (adding prerender headers when rendering 200.html) but if you think it might pose any issues, feel free to close.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 June 12, 2024 15:40
@danielroe danielroe self-assigned this Jun 12, 2024
@danielroe danielroe added the bug Something isn't working label Jun 12, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick look seems good. It would be nice if you can add it to the tests mainly because i am planning to have some major refactors on prerenderer and don't want it to cause a regression with fix of this PR

@pi0 pi0 merged commit e1f87c5 into main Jun 13, 2024
5 checks passed
@pi0 pi0 deleted the fix/prerendered-explicit-html branch June 13, 2024 09:32
@pi0 pi0 mentioned this pull request Jun 13, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants