Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): warn if runtime config is not serializable #2542

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

danielroe
Copy link
Collaborator

πŸ”— Linked issue

nuxt/nuxt#21466
nuxt/nuxt#13992

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Users may be under the impression they can set anything on runtimeConfig, e.g. Set(), Map(), functions, etc. This tries to check if it's a valid JSON object and if not - warn.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 June 17, 2024 16:20
@danielroe danielroe self-assigned this Jun 17, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pi0 pi0 merged commit e4f687d into v2 Jun 17, 2024
4 of 5 checks passed
@pi0 pi0 deleted the feat/check-runtime-config branch June 17, 2024 16:29
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants