Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(handler-meta): check for .name with undefined value in ObjectExpression #2565

Merged
merged 9 commits into from
Jun 26, 2024
Merged

fix(handler-meta): check for .name with undefined value in ObjectExpression #2565

merged 9 commits into from
Jun 26, 2024

Conversation

Saganic
Copy link
Contributor

@Saganic Saganic commented Jun 26, 2024

🔗 Linked issue

#2564

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Checks ObjectExpression keys and attemptes to use the value property as the key if name indefined, allowing for number or number-like keys.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: check for undefined .name value in ObjectExpression key and attempt to use .value instead fix(handler-meta): check for undefined .name value in ObjectExpression Jun 26, 2024
@pi0 pi0 changed the title fix(handler-meta): check for undefined .name value in ObjectExpression fix(handler-meta): check for .name with undefined value in ObjectExpression Jun 26, 2024
@pi0
Copy link
Member

pi0 commented Jun 26, 2024

Do you mind to update fixture as well? 🙏🏼

@Saganic
Copy link
Contributor Author

Saganic commented Jun 26, 2024

Do you mind to update fixture as well? 🙏🏼

Updated 4e4006e

@pi0 pi0 added the v2 label Jun 26, 2024
@pi0 pi0 merged commit 33fb776 into nitrojs:v2 Jun 26, 2024
4 checks passed
@Saganic Saganic deleted the fix/ast-allow-object-expressions-keys-with-no-name branch June 26, 2024 11:24
@pi0 pi0 mentioned this pull request Jun 27, 2024
Closed
@pi0 pi0 mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saganic @pi0