feat(deno-server): use output node_modules for start task
#2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
node_modulesnode_modules for start task
pi0
changed the title
node_modules for start tasknode_modules for start task
luc122c
pushed a commit
to luc122c/unjs-nitro
that referenced
this pull request
Aug 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nitro generates
.output/server/node_moduelsfor used dependencies, however deno does not use this directory (and instead tries to download all dependencies again on first run!).This PR removed old
--unstableand adds new--unstable-byonmflag by default to the start task. (this also speeds up our internal CI tests for deno-server by ~2x)