refactor: improve type definitions for CacheOptions #2700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Linked issue
N/A
โ Type of change
๐ Description
Hi!
This PR adds argument type inheritance from
defineCachedFunction
anddefineCachedEventHandler
to the arguments of functions in theCacheOptions
interface.I think this will improve DX, because:
CacheOptions
object.Example
We have some function we want to cache:
Before:
After:
I don't think docs are needed to updated, since explicitly typing is still a valid case.
TypeScript WILL complain if arguments are improperly typed explicitly. Iโm curious if this counts as a breaking change.
๐ Checklist