Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase): validate custom serverFunctionName #2773

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

jpsc
Copy link
Contributor

@jpsc jpsc commented Oct 3, 2024

πŸ”— Linked issue

Resolves #2643

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Normalize serverFunctionName to using underscore (_) instead of dashes (-).

Resolves #2643

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@jpsc jpsc requested a review from pi0 as a code owner October 3, 2024 13:28
src/presets/firebase/preset.ts Outdated Show resolved Hide resolved
src/presets/firebase/preset.ts Outdated Show resolved Hide resolved
@jpsc
Copy link
Contributor Author

jpsc commented Oct 4, 2024

Not sure how to properly validade this fix.

@jpsc jpsc changed the title fix(firebase): normalize serverFunctionName fix(firebase): validate serverFunctionName Oct 4, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pi0 pi0 changed the title fix(firebase): validate serverFunctionName fix(firebase): validate custom serverFunctionName Oct 8, 2024
@pi0 pi0 merged commit 1bf47ae into nitrojs:v2 Oct 8, 2024
4 checks passed
@jpsc jpsc deleted the fix/firebase-preset branch October 14, 2024 07:29
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt3 fails to build with preset when serverFunctionName is set
2 participants