Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache): set ttl for native expiration (with swr disabled) #2783

Merged
merged 6 commits into from
Oct 31, 2024
Merged

feat(cache): set ttl for native expiration (with swr disabled) #2783

merged 6 commits into from
Oct 31, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 10, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This change, adds ttl (in seconds) as transaction options to the underlying unstorage driver with .setItem so in case it has native invalidation support (currently, redis, cloudflare*, vercel-kv support it) so the cache entries are automatically evicted.

Note: This flag will be only set when swr is false.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 self-assigned this Oct 10, 2024
@pi0 pi0 marked this pull request as draft October 10, 2024 11:58
@pi0 @atinux
Update src/runtime/internal/cache.ts
52e231f 
Co-authored-by: Sébastien Chopin <seb@nuxt.com>
@pi0 pi0 added the cache label Oct 31, 2024
@pi0 pi0 marked this pull request as ready for review October 31, 2024 15:55
@pi0 pi0 changed the title feat(cache): set ttl for native expiration feat(cache): set ttl for native expiration (with swr disabled) Oct 31, 2024
@pi0 pi0 merged commit f9dd97d into v2 Oct 31, 2024
5 checks passed
@pi0 pi0 deleted the feat/cache-native-ttl branch October 31, 2024 16:05
@pi0 pi0 mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux left review comments

Assignees

@pi0 pi0

Labels
cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pi0 @atinux