Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for dev server and proxy #644

Merged
merged 11 commits into from
Dec 8, 2022
Merged

Conversation

manniL
Copy link
Contributor

@manniL manniL commented Nov 8, 2022

πŸ”— Linked issue

#641 - not resolving though

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Initial plan was to check why the proxy is failing. In the local setup, the proxy did not fail.
I've added some test for the proxy and for the dev preset in general to ensure

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@manniL manniL changed the title test: add proxy test case WIP - fixing dev proxy? Nov 8, 2022
@manniL manniL changed the title WIP - fixing dev proxy? test: add tests for dev server and proxy Nov 8, 2022
@manniL manniL marked this pull request as ready for review November 8, 2022 11:05
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #644 (ec0d4c4) into main (6541373) will increase coverage by 3.52%.
The diff coverage is n/a.

❗ Current head ec0d4c4 differs from pull request most recent head 6388149. Consider uploading reports for the commit 6388149 to get more accurate results

@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   68.53%   72.05%   +3.52%     
==========================================
  Files          57       57              
  Lines        5050     5050              
  Branches      497      548      +51     
==========================================
+ Hits         3461     3639     +178     
+ Misses       1582     1401     -181     
- Partials        7       10       +3     
Impacted Files Coverage Ξ”
src/dev/vfs.ts 9.27% <0.00%> (+2.06%) ⬆️
src/options.ts 86.95% <0.00%> (+2.79%) ⬆️
src/build.ts 49.70% <0.00%> (+15.20%) ⬆️
src/dev/server.ts 72.31% <0.00%> (+47.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

test/tests.ts Outdated Show resolved Hide resolved
test/tests.ts Outdated Show resolved Hide resolved
@manniL
Copy link
Contributor Author

manniL commented Nov 10, 2022

LGTM now from my side, thanks for the input πŸ‘πŸ»

@manniL manniL requested review from pi0 and danielroe and removed request for pi0 and danielroe November 10, 2022 10:02
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit ca47a3a into nitrojs:main Dec 8, 2022
@manniL manniL deleted the fix/proxy branch December 8, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants