Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize nitro plugin paths to url in development #732

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Dec 6, 2022

πŸ”— Linked issue

nuxt/nuxt#15249
Baroshem/nuxt-security#42

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We need to normalize plugins that are absolute paths (C:\test\something) to file URLs on windows before we generate the imports from them in dev/index.mjs.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Dec 6, 2022
@danielroe danielroe requested a review from pi0 December 6, 2022 12:19
@danielroe danielroe self-assigned this Dec 6, 2022
src/options.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #732 (9be3f2c) into main (f08708d) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     nuxt/framework#732      +/-   ##
==========================================
- Coverage   66.91%   66.87%   -0.04%     
==========================================
  Files          57       57              
  Lines        4232     4239       +7     
  Branches      460      460              
==========================================
+ Hits         2832     2835       +3     
- Misses       1397     1401       +4     
  Partials        3        3              
Impacted Files Coverage Ξ”
src/options.ts 86.23% <33.33%> (-1.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
unjs-nitro βœ… Ready (Inspect) Visit Preview Dec 6, 2022 at 1:10PM (UTC)

@danielroe danielroe requested a review from pi0 December 6, 2022 13:47
@pi0 pi0 changed the title fix: normalize nitro plugins to file urls on windows fix: normalize nitro plugin paths to url in development Dec 6, 2022
@pi0 pi0 merged commit 9715120 into main Dec 6, 2022
@pi0 pi0 deleted the fix/resolve-plugins branch December 6, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants