Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialise imports.imports #737

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: initialise imports.imports #737

merged 1 commit into from
Dec 7, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

apologies - a regression from #733 - see https://stackblitz.com/edit/nuxt-starter-basw97 for a reproduction.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Dec 6, 2022
@danielroe danielroe requested a review from pi0 December 6, 2022 22:05
@danielroe danielroe self-assigned this Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #737 (f5692b2) into main (f08708d) will decrease coverage by 0.17%.
The diff coverage is 26.31%.

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   66.91%   66.74%   -0.18%     
==========================================
  Files          57       57              
  Lines        4232     4249      +17     
  Branches      460      461       +1     
==========================================
+ Hits         2832     2836       +4     
- Misses       1397     1410      +13     
  Partials        3        3              
Impacted Files Coverage Ξ”
src/options.ts 83.56% <26.31%> (-3.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit e4ed8d2 into main Dec 7, 2022
@pi0 pi0 deleted the fix/init-imports branch December 7, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants