Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enable api type tests and fix type assertion #772

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Dec 20, 2022

This reverts commit 1d9102a.

πŸ”— Linked issue

closes #771

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #772 (efdf196) into main (1d9102a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files          57       57           
  Lines        5209     5209           
  Branches      568      568           
=======================================
  Hits         3650     3650           
  Misses       1550     1550           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 3d48658 into main Dec 21, 2022
@pi0 pi0 deleted the fix/type-assertion branch December 21, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants