Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify, aws): omit cookies from v1 response #834

Merged
merged 6 commits into from
Jan 16, 2023
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jan 13, 2023

πŸ”— Linked issue

resolves #504
also nuxt/nuxt#15361

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This omits responding with cookies on aws lambda v1 format.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jan 13, 2023
@danielroe danielroe requested a review from pi0 January 13, 2023 14:02
@danielroe danielroe self-assigned this Jan 13, 2023
@pi0
Copy link
Member

pi0 commented Jan 13, 2023

Have you had a chance to test changes?

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #834 (86e7bf0) into main (8194ee4) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     nuxt/framework#834      +/-   ##
==========================================
- Coverage   69.93%   69.88%   -0.05%     
==========================================
  Files          57       57              
  Lines        5312     5307       -5     
  Branches      594      594              
==========================================
- Hits         3715     3709       -6     
- Misses       1588     1589       +1     
  Partials        9        9              
Impacted Files Coverage Ξ”
src/presets/netlify.ts 60.00% <0.00%> (-1.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe
Copy link
Member Author

I've tested changes within netlify environment but haven't directly on AWS. I'm going directly off the docs here: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html.

Testing would be welcome.

@pi0 pi0 changed the title fix(aws-lambda): omit cookies from v1 response fix(netlify, aws): omit cookies from v1 response Jan 16, 2023
@pi0 pi0 merged commit 5e484c3 into main Jan 16, 2023
@pi0 pi0 deleted the fix/lambda-cookies branch January 16, 2023 12:57
@utybo
Copy link

utybo commented Jan 16, 2023

Hi! I just tested this on AWS Lambda, I can confirm this fixes nuxt/framework#504 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt 3.0.0-rc.9 with Nitro 0.5.0 configuration error: Malformed Lambda proxy response
3 participants