Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(digitalocean): update deployment guide #862

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

christopher4lis
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Current docs are incomplete as they don't specify how to set up a run command after build. This should fix that. Others have this issue as shown here: https://www.youtube.com/watch?v=hANbHC90xug. Thanks to Jahid Anowar for figuring it out.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Current docs are incomplete as they don't specify how to set up a run command after build. This should fix that. Others have this issue as shown here: https://www.youtube.com/watch?v=hANbHC90xug. Thanks to Jahid Anowar for figuring it out.
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #862 (19d0414) into main (456f82a) will decrease coverage by 0.02%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   67.15%   67.13%   -0.02%     
==========================================
  Files          59       59              
  Lines        5782     5785       +3     
  Branches      613      614       +1     
==========================================
+ Hits         3883     3884       +1     
- Misses       1891     1893       +2     
  Partials        8        8              
Impacted Files Coverage Ξ”
src/rollup/plugins/externals.ts 94.48% <77.77%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title docs: update section regarding deployment on Digital Ocean docs(digitalocean): update deployment guide Jan 23, 2023
@pi0 pi0 merged commit 4193603 into nitrojs:main Jan 25, 2023
@pi0
Copy link
Member

pi0 commented Jan 25, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants