Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): update preview command to serve matching routes #864

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#14454

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There is a bug in serve -s that renders all responses, not just 404s, with base index.html: vercel/serve#722. This PR removes the flag. 404s will now be rendered with /404.html, which Nuxt now outputs, so this should not have any downside downstream on Nuxt - or, I think, in any other project depending on this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jan 22, 2023
@danielroe danielroe requested a review from pi0 January 22, 2023 13:45
@danielroe danielroe self-assigned this Jan 22, 2023
@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #864 (a6fd2f8) into main (63e250d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   67.13%   67.13%           
=======================================
  Files          59       59           
  Lines        5785     5785           
  Branches      614      614           
=======================================
  Hits         3884     3884           
  Misses       1893     1893           
  Partials        8        8           
Impacted Files Coverage Ξ”
src/presets/nitro-prerender.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: don't serve all SSG previews with base index.html fix(prerender): update preview command to serve matching routes Jan 23, 2023
@pi0 pi0 merged commit dc4e2f1 into main Jan 23, 2023
@pi0 pi0 deleted the fix/preview-index branch January 23, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants