fix: update azure SWA preset and update node versions detection #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Apr 7, 2022
| @@ -26,7 +26,18 @@ async function writeRoutes (nitro) { | |||
| version: '2.0' | |||
| } | |||
|
|
|||
| let nodeVersion = '16' | |||
| try { | |||
| const currentNodeVersion = fse.readJSONSync(join(nitro.options.rootDir, 'package.json')).engines.node | |||
There was a problem hiding this comment.
Isn't engines.node optional? Are we doing try/catch to ignore this?
There was a problem hiding this comment.
Yes, and also if the file doesn't exist. Implementation from https://github.com/unjs/nitropack/blob/305c49853d514ceb00342107a7affdbd9500f5f2/src/presets/firebase.ts#L57-L65.
But maybe might be better to just grab from process?
There was a problem hiding this comment.
I like the idea of falling back to process.versions :)
danielroe
changed the title
danielroe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This is now how we take advantage of the new Node runtimes with Azure SWA: https://docs.microsoft.com/en-us/azure/static-web-apps/configuration#platform