Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use rootDir for providers output instead of workspaceDir #491

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#14871

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Confirmed with Vercel team - we need to output vercel build output in project root directory.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 12, 2022
@danielroe danielroe requested a review from pi0 September 12, 2022 19:38
@danielroe danielroe self-assigned this Sep 12, 2022
@pi0
Copy link
Member

pi0 commented Sep 12, 2022

Would you please also revert for other providers?

@pi0 pi0 changed the title fix: use rootDir for vercel output fix: use rootDir for providers output instead of workspaceDir Sep 12, 2022
@pi0 pi0 merged commit c605563 into main Sep 12, 2022
@pi0 pi0 deleted the fix/vercel-root branch September 12, 2022 20:02
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants