Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing name and version fields to .output/package.json #516

Conversation

TheDutchCoder
Copy link
Contributor

πŸ”— Linked issue

#508

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change adds a name and version field to the generated package.json for the aws-lambda preset.

When building and deploying code with AWS SAM, there's a validation step running on the package.json file, which requires name and version to be set.

Resolves #508

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Let me know if this requires a documentation update (I don't think so)

@pi0 pi0 changed the title refactor: ♻️ Add missing name/version to package.json fix: add missing name and version fields to .output/package.json Sep 19, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pi0 pi0 merged commit 9f3f017 into nitrojs:main Sep 19, 2022
@TheDutchCoder TheDutchCoder deleted the bug/add-missing-name-and-vvrsion-to-package-json branch September 19, 2022 13:37
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated package.json is not valid
2 participants