Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build does not include required files from firebase #84

Closed
pi0 opened this issue Apr 12, 2022 · 8 comments
Closed

build does not include required files from firebase #84

pi0 opened this issue Apr 12, 2022 · 8 comments
Assignees
Labels

Comments

@pi0
Copy link
Member

pi0 commented Apr 12, 2022

Environment

  • Operating System: Windows_NT
  • Node Version: v16.13.1
  • Nuxt Version: 3.0.0-27338323.1e98259
  • Package Manager: npm@8.3.0
  • Bundler: Vite
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

https://github.com/AlexDicy/nuxt-min-reproduction

Describe the bug

Moved from nuxt/nuxt#13131

Additional context

No response

Logs

No response

@pi0 pi0 added bug Something isn't working preset:firebase labels Apr 12, 2022
@pi0 pi0 assigned pi0 and danielroe and unassigned pi0 Apr 12, 2022
@pi0
Copy link
Member Author

pi0 commented Apr 12, 2022

@danielroe Can you please check on this?

@pi0
Copy link
Member Author

pi0 commented May 4, 2022

@danielroe Kindly reminder for this :)

@danielroe
Copy link
Member

I can't reproduce this issue.

Steps:

  1. upgraded your project to Nuxt RC (also deleted lockfile and installed with yarn).
  2. added required firebase dependencies. Here's the new package.json:
{
  "private": true,
  "scripts": {
    "dev": "nuxt dev",
    "build": "nuxt build",
    "start": "node .output/server/index.mjs"
  },
  "devDependencies": {
    "firebase-admin": "^10.1.0",
    "firebase-functions": "^3.20.1",
    "firebase-functions-test": "^2.0.0",
    "nuxt": "npm:nuxt3@latest"
  },
  "dependencies": {
    "firebase": "^9.6.1"
  }
}
  1. ran NITRO_PRESET=firebase yarn build
  2. updated firebase.json with my test project id.
  3. ran firebase deploy --project <myprojectid>

Is it possible the issue is that you didn't add the required dependencies?

@AlexDicy
Copy link

AlexDicy commented May 5, 2022

Just to make sure: The reproduction project was not meant to be run in a firebase environment, but in a nodejs server

@danielroe
Copy link
Member

Sorry, my mistake!

@Abhayprince
Copy link

danielroe Any update on this, I am having the same issue with "nuxt": "^3.5.2" node 18 and "firebase": "^10.0.0" ?

AlexDicy did you got it working by some alternate way?

@AlexDicy
Copy link

AlexDicy commented Jul 8, 2023

@Abhayprince I don't remember, unfortunately. I might have used a different version at the time

@pi0
Copy link
Member Author

pi0 commented May 16, 2024

Closing since this issue had been stalled for a while. Please feel free to open a new issue with fresh reproduction if having similar issues 🙏🏼

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants