Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unimport v3 built-in type gen for dirs #877

Closed
pi0 opened this issue Jan 25, 2023 · 6 comments · Fixed by #994
Closed

Use unimport v3 built-in type gen for dirs #877

pi0 opened this issue Jan 25, 2023 · 6 comments · Fixed by #994
Assignees
@antfu

Comments

@pi0
Copy link
Member

pi0 commented Jan 25, 2023

Dep upgraded in #869

Context: unjs/unimport#213

/cc @antfu Do you mind helping on this?
@antfu
Copy link
Collaborator

antfu commented Jan 25, 2023

Do we have an example/playground with this feature set up? If not, should we create one for that?

@pi0
Copy link
Member Author

pi0 commented Jan 25, 2023

Would be nice adding to playground indeed 👍🏼 (i think added a basic test in fixture)

@pi0
Copy link
Member Author

pi0 commented Jan 25, 2023

You can also reproduce .ts issue by commenting out this line: https://github.com/unjs/nitro/blob/963c587308561cd24841cc279f0bc4f2b3db4d69/src/build.ts#L102

Also dirs is still not effective in generated types.

@antfu antfu self-assigned this Jan 29, 2023
@pi0 pi0 changed the title Use unimport v2 built-in type gen for dirs Use unimport v3 built-in type gen for dirs Feb 24, 2023
@pi0
Copy link
Member Author

pi0 commented Feb 24, 2023

Upgraded to v3 (#982). We also have an issue when adding new utility, full server reload is needed. need your help @antfu 🙏🏼

@antfu
Copy link
Collaborator

antfu commented Feb 24, 2023

Theoretically v3 does not change the behaviour, but anyway I will have a look after lunch

@pi0
Copy link
Member Author

pi0 commented Feb 24, 2023

Issue is from v2 :D

@antfu antfu mentioned this issue Feb 24, 2023
Merged
7 tasks
@pi0 pi0 closed this as completed in #994 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antfu antfu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use unimport built-in type gen for dirs nitrojs/nitro
2 participants
@pi0 @antfu