Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add normalizeAliases and filename in /utils subpath #34

Merged
merged 15 commits into from
Aug 10, 2022
Merged

feat: add normalizeAliases and filename in /utils subpath #34

merged 15 commits into from
Aug 10, 2022

Conversation

danielroe
Copy link
Member

#33

@danielroe danielroe added the enhancement New feature or request label Aug 5, 2022
@danielroe danielroe requested a review from pi0 August 5, 2022 21:02
@danielroe danielroe self-assigned this Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022 •
edited
Loading

Codecov Report

Merging #34 (2b053d6) into main (34a55cf) will increase coverage by 0.34%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   63.52%   63.86%   +0.34%     
==========================================
  Files           3        4       +1     
  Lines         244      274      +30     
  Branches       89       99      +10     
==========================================
+ Hits          155      175      +20     
- Partials       89       99      +10
Impacted Files Coverage Δ
src/_internal.ts 42.85% <42.85%> (ø)
src/utils.ts 66.66% <64.28%> (+23.80%) ⬆️
src/path.ts 63.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pi0
pi0 reviewed Aug 7, 2022
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
pi0
pi0 reviewed Aug 7, 2022
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
pi0
pi0 reviewed Aug 7, 2022
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
pi0
pi0 reviewed Aug 7, 2022
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 August 8, 2022 11:52
@danielroe
Copy link
Member Author

adding tests

@danielroe danielroe changed the title feat: add /utils subpath with sortPaths, resolveAliases and filename feat: add /utils subpath with sortAliases, resolveAliases and filename Aug 10, 2022
@pi0 pi0 changed the title feat: add /utils subpath with sortAliases, resolveAliases and filename feat: add normalizeAliases and filename in /utils subpath Aug 10, 2022
@pi0 pi0 merged commit 1ece780 into main Aug 10, 2022
@pi0 pi0 deleted the feat/utils branch August 10, 2022 14:56
@danielroe danielroe mentioned this pull request Aug 29, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0