Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(basename): handle empty extensions #61

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix(basename): handle empty extensions #61

merged 1 commit into from
Sep 15, 2022

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe requested a review from pi0 September 15, 2022 08:52
@danielroe danielroe self-assigned this Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #61 (146d26d) into main (e9f50b7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          295       295           
  Branches       106       106           
=========================================
  Hits           295       295           
Impacted Files Coverage Δ
src/path.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: handle undefined/null extension for basename fix(basename): handle empty extensions Sep 15, 2022
@pi0 pi0 merged commit b0661cb into main Sep 15, 2022
@pi0 pi0 deleted the fix/undefined-ext branch September 15, 2022 10:01
unicornware added a commit to flex-development/mkbuild that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants