Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the stringifyParsedURL method support non-ParseDURL type passing? #166

Closed
1 task
SGAMERyu opened this issue Aug 17, 2023 · 1 comment
Closed
1 task

Comments

@SGAMERyu
Copy link

Describe the feature

When I call stringifyParsedURL method, pass parameters I only passed the protocol and the combination of the host, other fields are not passed, this will make them return to an www.example.comundefinedundefined url,

stringifyParsedURL({
    protocol,
    host,
 });

Can we support this parameter passing? The reason for this demand is that I am doing a download website favicon.ico file function, which needs to be automatically obtained according to the url entered by the user, without entering the complete ico url, the server will automatically splicing

If you agree, I would like to offer pr for this, thank you for writing such a good library of Ufos

Additional information

  • Would you be willing to help implement this feature?
@pi0 pi0 closed this as completed in 4e4ba93 Aug 24, 2023
@pi0
Copy link
Member

pi0 commented Aug 24, 2023

That's a good idea! This will be supported in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants