chore: apply new lint rules

demo/vite.config.ts

@@ -19,7 +19,7 @@ export default defineConfig({
       configureServer(server) {
         const storage = createStorage();
         const storageServer = createStorageServer(storage);
-        // eslint-disable-next-line unicorn/prefer-module
+
         storage.mount("/src", fsdriver({ base: resolve(__dirname, "..") }));
         server.middlewares.use("/storage", storageServer.handle);
       },

src/_utils.ts

@@ -47,7 +47,7 @@ export function stringify(value: any): string {
 }
 
 function checkBufferSupport() {
-  if (typeof Buffer === undefined) {
+  if (typeof Buffer === "undefined") {
     throw new TypeError("[unstorage] Buffer is not supported!");
   }
 }

src/cli.ts

@@ -9,7 +9,6 @@ async function main() {
   const arguments_ = mri(process.argv.splice(2));
 
   if (arguments_.help) {
-    // eslint-disable-next-line no-console
     console.log("Usage: npx unstorage [rootDir]");
     // eslint-disable-next-line unicorn/no-process-exit
     process.exit(0);
@@ -31,7 +30,6 @@ async function main() {
 
 // eslint-disable-next-line unicorn/prefer-top-level-await
 main().catch((error) => {
-  // eslint-disable-next-line no-console
   console.error(error);
   // eslint-disable-next-line unicorn/no-process-exit
   process.exit(1);

src/drivers/azure-key-vault.ts

@@ -116,7 +116,7 @@ function encode(value: string): string {
   let encoded = Buffer.from(value).toString("base64");
   for (const key in base64Map) {
     encoded = encoded.replace(
-      new RegExp(key.replace(/[.*+?^${}()|[\]\\]/g, "\\$&"), "g"),
+      new RegExp(key.replace(/[$()*+.?[\\\]^{|}]/g, "\\$&"), "g"),
       base64Map[key]
     );
   }

src/drivers/azure-storage-blob.ts

@@ -172,7 +172,9 @@ async function blobToString(blob: Blob) {
     fileReader.onloadend = (ev) => {
       resolve(ev.target?.result);
     };
+    // eslint-disable-next-line unicorn/prefer-add-event-listener
     fileReader.onerror = reject;
+    // eslint-disable-next-line unicorn/prefer-blob-reading-methods
     fileReader.readAsText(blob);
   });
 }

src/drivers/cloudflare-kv-http.ts

@@ -157,7 +157,9 @@ export default defineDriver<KVHTTPOptions>((opts) => {
     }
 
     const firstPage = await kvFetch("/keys", { params });
-    firstPage.result.forEach(({ name }: { name: string }) => keys.push(name));
+    for (const item of firstPage.result as { name: string }[]) {
+      keys.push(item.name);
+    }
 
     const cursor = firstPage.result_info.cursor;
     if (cursor) {
@@ -166,25 +168,23 @@ export default defineDriver<KVHTTPOptions>((opts) => {
 
     while (params.cursor) {
       const pageResult = await kvFetch("/keys", { params });
-      pageResult.result.forEach(({ name }: { name: string }) =>
-        keys.push(name)
-      );
-      const pageCursor = pageResult.result_info.cursor;
-      if (pageCursor) {
-        params.cursor = pageCursor;
-      } else {
-        params.cursor = undefined;
+      for (const item of pageResult.result as { name: string }[]) {
+        keys.push(item.name);
       }
+      const pageCursor = pageResult.result_info.cursor;
+      params.cursor = pageCursor ? pageCursor : undefined;
     }
     return keys;
   };
 
   const clear = async () => {
     const keys: string[] = await getKeys();
     // Split into chunks of 10000, as the API only allows for 10,000 keys at a time
+    // TODO: Avoid reduce
+    // eslint-disable-next-line unicorn/no-array-reduce
     const chunks = keys.reduce<string[][]>(
       (acc, key, i) => {
-        if (i % 10000 === 0) {
+        if (i % 10_000 === 0) {
           acc.push([]);
         }
         acc[acc.length - 1].push(key);

src/drivers/cloudflare-r2-binding.ts

@@ -30,7 +30,7 @@ export default defineDriver((opts: CloudflareR2Options = {}) => {
       const binding = getR2Binding(opts.binding);
       return (await binding.head(key)) !== null;
     },
-    async getMeta(key, topts) {
+    async getMeta(key) {
       key = r(key);
       const binding = getR2Binding(opts.binding);
       const obj = await binding.head(key);

src/drivers/fs-lite.ts

@@ -1,5 +1,5 @@
-import { existsSync, promises as fsp, Stats } from "fs";
-import { resolve, join } from "path";
+import { existsSync, promises as fsp, Stats } from "node:fs";
+import { resolve, join } from "node:path";
 import { createError, createRequiredError, defineDriver } from "./utils";
 import {
   readFile,
@@ -8,7 +8,6 @@ import {
   rmRecursive,
   unlink,
 } from "./utils/node-fs";
-import anymatch from "anymatch";
 
 export interface FSStorageOptions {
   base?: string;
@@ -17,7 +16,7 @@ export interface FSStorageOptions {
   noClear?: boolean;
 }
 
-const PATH_TRAVERSE_RE = /\.\.\:|\.\.$/;
+const PATH_TRAVERSE_RE = /\.\.:|\.\.$/;
 
 const DRIVER_NAME = "fs-lite";
 

src/drivers/fs.ts

@@ -1,5 +1,5 @@
-import { existsSync, promises as fsp, Stats } from "fs";
-import { resolve, relative, join } from "path";
+import { existsSync, promises as fsp, Stats } from "node:fs";
+import { resolve, relative, join } from "node:path";
 import { FSWatcher, WatchOptions, watch } from "chokidar";
 import { createError, createRequiredError, defineDriver } from "./utils";
 import {
@@ -19,7 +19,7 @@ export interface FSStorageOptions {
   watchOptions?: WatchOptions;
 }
 
-const PATH_TRAVERSE_RE = /\.\.\:|\.\.$/;
+const PATH_TRAVERSE_RE = /\.\.:|\.\.$/;
 
 const DRIVER_NAME = "fs";
 

src/drivers/github.ts

@@ -149,9 +149,7 @@ async function fetchFiles(opts: GithubOptions) {
       if (node.type !== "blob" || !node.path.startsWith(prefix)) {
         continue;
       }
-      const key: string = node.path
-        .substring(prefix.length)
-        .replace(/\//g, ":");
+      const key: string = node.path.slice(prefix.length).replace(/\//g, ":");
       files[key] = {
         meta: {
           sha: node.sha,

src/drivers/indexedb.ts

@@ -31,7 +31,7 @@ export default defineDriver((opts: IDBKeyvalOptions = {}) => {
     options: opts,
     async hasItem(key) {
       const item = await get(makeKey(key), customStore);
-      return typeof item === "undefined" ? false : true;
+      return item === undefined ? false : true;
     },
     async getItem(key) {
       const item = await get(makeKey(key), customStore);

src/drivers/localstorage.ts

@@ -10,7 +10,7 @@ const DRIVER_NAME = "localstorage";
 
 export default defineDriver((opts: LocalStorageOptions = {}) => {
   if (!opts.window) {
-    opts.window = typeof window !== "undefined" ? window : undefined;
+    opts.window = typeof window === "undefined" ? undefined : window;
   }
   if (!opts.localStorage) {
     opts.localStorage = opts.window?.localStorage;
@@ -48,12 +48,12 @@ export default defineDriver((opts: LocalStorageOptions = {}) => {
       return Object.keys(opts.localStorage!);
     },
     clear() {
-      if (!opts.base) {
-        opts.localStorage!.clear();
-      } else {
+      if (opts.base) {
         for (const key of Object.keys(opts.localStorage!)) {
           opts.localStorage?.removeItem(key);
         }
+      } else {
+        opts.localStorage!.clear();
       }
       if (opts.window && _storageListener) {
         opts.window.removeEventListener("storage", _storageListener);

src/drivers/lru-cache.ts

@@ -44,7 +44,7 @@ export default defineDriver((opts: LRUDriverOptions = {}) => {
       cache.delete(key);
     },
     getKeys() {
-      return Array.from(cache.keys());
+      return [...cache.keys()];
     },
     clear() {
       cache.clear();
@@ -56,15 +56,19 @@ export default defineDriver((opts: LRUDriverOptions = {}) => {
 });
 
 function byteLength(value: any) {
-  if (typeof Buffer !== undefined) {
+  if (typeof Buffer !== "undefined") {
     try {
       return Buffer.byteLength(value);
-    } catch {}
+    } catch {
+      // ignore
+    }
   }
   try {
     return typeof value === "string"
       ? value.length
       : JSON.stringify(value).length;
-  } catch {}
+  } catch {
+    // ignore
+  }
   return 0;
 }

src/drivers/memory.ts

@@ -27,7 +27,7 @@ export default defineDriver<void>(() => {
       data.delete(key);
     },
     getKeys() {
-      return Array.from(data.keys());
+      return [...data.keys()];
     },
     clear() {
       data.clear();

src/drivers/overlay.ts

@@ -17,10 +17,11 @@ export default defineDriver((options: OverlayStorageOptions) => {
     async hasItem(key, opts) {
       for (const layer of options.layers) {
         if (await layer.hasItem(key, opts)) {
-          if (layer === options.layers[0]) {
-            if ((await options.layers[0]?.getItem(key)) === OVERLAY_REMOVED) {
-              return false;
-            }
+          if (
+            layer === options.layers[0] &&
+            (await options.layers[0]?.getItem(key)) === OVERLAY_REMOVED
+          ) {
+            return false;
           }
           return true;
         }
@@ -54,7 +55,7 @@ export default defineDriver((options: OverlayStorageOptions) => {
           return keys.map((key) => normalizeKey(key));
         })
       );
-      const uniqueKeys = Array.from(new Set(allKeys.flat()));
+      const uniqueKeys = [...new Set(allKeys.flat())];
       const existingKeys = await Promise.all(
         uniqueKeys.map(async (key) => {
           if ((await options.layers[0]?.getItem(key)) === OVERLAY_REMOVED) {

src/drivers/planetscale.ts

@@ -1,4 +1,4 @@
-import { createError, createRequiredError, defineDriver } from "./utils";
+import { createRequiredError, defineDriver } from "./utils";
 import type { ExecutedQuery, Connection } from "@planetscale/database";
 import { connect } from "@planetscale/database";
 import { fetch } from "node-fetch-native";

src/drivers/redis.ts

@@ -66,7 +66,7 @@ export default defineDriver((opts: RedisOptions = {}) => {
       return value ?? null;
     },
     async setItem(key, value, tOptions) {
-      let ttl = tOptions?.ttl ?? opts.ttl;
+      const ttl = tOptions?.ttl ?? opts.ttl;
       if (ttl) {
         await getRedisClient().set(p(key), value, "EX", ttl);
       } else {

src/drivers/session-storage.ts

@@ -1,4 +1,4 @@
-import { createError, createRequiredError, defineDriver } from "./utils";
+import { createRequiredError, defineDriver } from "./utils";
 
 export interface SessionStorageOptions {
   base?: string;
@@ -10,7 +10,7 @@ const DRIVER_NAME = "session-storage";
 
 export default defineDriver((opts: SessionStorageOptions = {}) => {
   if (!opts.window) {
-    opts.window = typeof window !== "undefined" ? window : undefined;
+    opts.window = typeof window === "undefined" ? undefined : window;
   }
   if (!opts.sessionStorage) {
     opts.sessionStorage = opts.window?.sessionStorage;
@@ -48,12 +48,12 @@ export default defineDriver((opts: SessionStorageOptions = {}) => {
       return Object.keys(opts.sessionStorage!);
     },
     clear() {
-      if (!opts.base) {
-        opts.sessionStorage!.clear();
-      } else {
+      if (opts.base) {
         for (const key of Object.keys(opts.sessionStorage!)) {
           opts.sessionStorage?.removeItem(key);
         }
+      } else {
+        opts.sessionStorage!.clear();
       }
       if (opts.window && _storageListener) {
         opts.window.removeEventListener("storage", _storageListener);

src/drivers/utils/index.ts

@@ -17,7 +17,10 @@ export function normalizeKey(key: string | undefined): string {
 }
 
 export function joinKeys(...keys: string[]) {
-  return keys.map(normalizeKey).filter(Boolean).join(":");
+  return keys
+    .map((key) => normalizeKey(key))
+    .filter(Boolean)
+    .join(":");
 }
 
 export function createError(

src/drivers/utils/node-fs.ts

@@ -1,5 +1,5 @@
-import { Dirent, existsSync, promises as fsPromises } from "fs";
-import { resolve, dirname } from "path";
+import { Dirent, existsSync, promises as fsPromises } from "node:fs";
+import { resolve, dirname } from "node:path";
 
 function ignoreNotfound(err: any) {
   return err.code === "ENOENT" || err.code === "EISDIR" ? null : err;

src/server.ts

@@ -35,7 +35,7 @@ export interface StorageServerOptions {
 
 export function createH3StorageHandler(
   storage: Storage,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
   opts: StorageServerOptions = {}
 ): EventHandler {
   return eventHandler(async (event) => {

src/storage.ts

@@ -414,7 +414,7 @@ export function createStorage<T extends StorageValue>(
           .then((unwatcher) => {
             context.unwatch[base] = unwatcher;
           })
-          .catch(console.error); // eslint-disable-line no-console
+          .catch(console.error);
       }
       return storage;
     },

test/drivers/azure-key-vault.test.ts

@@ -9,5 +9,5 @@ describe.skip(
       driver: driver({ vaultName: "testunstoragevault" }),
     });
   },
-  { timeout: 80000 }
+  { timeout: 80_000 }
 ); // 60s as the Azure Key Vault need to delete and purge the secret before it can be created again.

test/drivers/azure-storage-blob.test.ts

@@ -1,8 +1,8 @@
-import { describe, it, expect, beforeAll, afterAll } from "vitest";
+import { describe, beforeAll, afterAll } from "vitest";
 import driver from "../../src/drivers/azure-storage-blob";
 import { testDriver } from "./utils";
 import { BlobServiceClient } from "@azure/storage-blob";
-import { ChildProcess, exec } from "child_process";
+import { ChildProcess, exec } from "node:child_process";
 
 describe.skip("drivers: azure-storage-blob", () => {
   let azuriteProcess: ChildProcess;

test/drivers/azure-storage-table.test.ts

@@ -1,8 +1,8 @@
-import { describe, it, expect, beforeAll, afterAll } from "vitest";
+import { describe, beforeAll, afterAll } from "vitest";
 import driver from "../../src/drivers/azure-storage-table";
 import { testDriver } from "./utils";
 import { TableClient } from "@azure/data-tables";
-import { ChildProcess, exec } from "child_process";
+import { ChildProcess, exec } from "node:child_process";
 
 describe.skip("drivers: azure-storage-table", () => {
   let azuriteProcess: ChildProcess;

test/drivers/capacitor-preferences.test.ts

@@ -6,7 +6,7 @@ import { afterEach } from "node:test";
 vi.mock("@capacitor/preferences", () => {
   const data = new Map<string, string>();
 
-  const keys = vi.fn(() => Promise.resolve({ keys: Array.from(data.keys()) }));
+  const keys = vi.fn(() => Promise.resolve({ keys: [...data.keys()] }));
   const get = vi.fn(({ key }) =>
     Promise.resolve({ value: data.get(key) ?? null })
   );

test/drivers/cloudflare-kv-binding.test.ts

@@ -30,7 +30,7 @@ const mockBinding: KVNamespace = {
 describe("drivers: cloudflare-kv", () => {
   testDriver({
     driver: CloudflareKVBinding({ binding: mockBinding, base: "base" }),
-    async additionalTests(ctx) {
+    async additionalTests() {
       test("snapshot", async () => {
         expect(await snapshot(mockStorage, "")).toMatchInlineSnapshot(`
           {