Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeMeta option for removeItem type and default value incorrect in docs #280

Closed
Timbological opened this issue Jul 31, 2023 · 0 comments · Fixed by #281
Closed

removeMeta option for removeItem type and default value incorrect in docs #280

Timbological opened this issue Jul 31, 2023 · 0 comments · Fixed by #281

Comments

@Timbological
Copy link
Contributor

Environment

N/A

Reproduction

removeItem("foo:bar", true) will remove meta
removeItem("foo:bar", {removeMeta: true}) won't remove meta
removeItem("foo:bar", {removeMata: true}) will remove meta
removeItem("foo:bar") wont' remove meta

Describe the bug

removeMeta option is misspelled as "removeMata" meaning setting "removeMeta" option doesn't work

Also docs imply removeMeta is true by default which is not the case leading to unexpected behaviour when not supplying removeMeta option

Additional context

Also I noticed the removeItem function is commented as going to be removed in the next major release, why is that?

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant