From 6114d9380a2a6ac03cb931048dabad9a40ec0c9c Mon Sep 17 00:00:00 2001 From: Youssef1313 Date: Thu, 12 Jan 2023 13:13:35 +0200 Subject: [PATCH] build: Refactor how pages are included --- src/Common_ViewLibraryProps/Globbing.props | 6 +--- src/Directory.Build.props | 4 +++ src/Directory.Build.targets | 4 +++ src/PlatformItemGroups.props | 5 --- .../UITests.Shared/ItemExclusions.props | 6 ++-- ...o.UI.SourceGenerators.netcore.Tests.csproj | 2 +- .../XamlGenerationTests.csproj | 4 --- src/Uno.CrossTargetting.props | 6 ---- src/Uno.UI.FluentTheme.v1/FluentMerge.targets | 32 +++---------------- src/Uno.UI.FluentTheme.v2/FluentMerge.targets | 32 +++---------------- src/Uno.UI.FluentTheme/FluentMerge.targets | 32 +++---------------- src/Uno.UI.Maps/Uno.UI.Maps.csproj | 5 ++- .../Uno.UI.RuntimeTests.Skia.csproj | 8 ----- .../Uno.UI.RuntimeTests.Wasm.csproj | 8 ----- .../Uno.UI.RuntimeTests.csproj | 12 ++----- .../Uno.UI.RuntimeTests.netcoremobile.csproj | 5 --- .../Uno.UI.Tests.ViewLibrary.csproj | 5 --- src/Uno.UI.Tests/Uno.UI.Tests.csproj | 17 ++-------- .../Uno.UI.Toolkit.Reference.csproj | 5 --- src/Uno.UI.Toolkit/Uno.UI.Toolkit.Skia.csproj | 5 --- src/Uno.UI.Toolkit/Uno.UI.Toolkit.Wasm.csproj | 5 --- src/Uno.UI.Toolkit/Uno.UI.Toolkit.csproj | 15 ++------- .../Uno.UI.Toolkit.netcoremobile.csproj | 5 --- src/Uno.UI/Uno.UI.Reference.csproj | 2 +- src/Uno.UI/Uno.UI.Skia.csproj | 9 +----- src/Uno.UI/Uno.UI.Wasm.csproj | 9 +----- src/Uno.UI/Uno.UI.csproj | 29 +++-------------- src/Uno.UI/Uno.UI.netcoremobile.csproj | 29 +++-------------- 28 files changed, 54 insertions(+), 252 deletions(-) diff --git a/src/Common_ViewLibraryProps/Globbing.props b/src/Common_ViewLibraryProps/Globbing.props index 89c168a8a68c..98824987543e 100644 --- a/src/Common_ViewLibraryProps/Globbing.props +++ b/src/Common_ViewLibraryProps/Globbing.props @@ -1,11 +1,7 @@ - %(Filename) - - - - \ No newline at end of file + diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 38aa4d9c8a4d..0c13768e49a5 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -9,6 +9,8 @@ $(NoWarn);MSB4011 $(NoWarn);NU1505 + true + portable True $(BUILD_REPOSITORY_URI) @@ -58,6 +60,8 @@ True + + false diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets index eaa10063df1f..5b0a0cc90bac 100644 --- a/src/Directory.Build.targets +++ b/src/Directory.Build.targets @@ -6,6 +6,10 @@ $(AssemblyName) ($(TargetFramework) $(UnoRuntimeIdentifier)) + + + + - - - - diff --git a/src/Uno.UI.FluentTheme.v1/FluentMerge.targets b/src/Uno.UI.FluentTheme.v1/FluentMerge.targets index a27211087bc7..89e474110098 100644 --- a/src/Uno.UI.FluentTheme.v1/FluentMerge.targets +++ b/src/Uno.UI.FluentTheme.v1/FluentMerge.targets @@ -1,9 +1,9 @@  - $(MSBuildThisFileDirectory)Resources\**\*.xaml + $(MSBuildThisFileDirectory)Resources\**\*.xaml - + @@ -35,31 +35,9 @@ - - - - - - - - - - - - - - - - - - - - - - - - - + + false + $(MSBuildThisFileDirectory)..\SourceGenerators\Uno.UI.Tasks\bin\$(Configuration)_Shadow diff --git a/src/Uno.UI.FluentTheme.v2/FluentMerge.targets b/src/Uno.UI.FluentTheme.v2/FluentMerge.targets index de06fd411cd6..82b2ea4a0aec 100644 --- a/src/Uno.UI.FluentTheme.v2/FluentMerge.targets +++ b/src/Uno.UI.FluentTheme.v2/FluentMerge.targets @@ -1,9 +1,9 @@  - $(MSBuildThisFileDirectory)Resources\**\*.xaml + $(MSBuildThisFileDirectory)Resources\**\*.xaml - + @@ -34,31 +34,9 @@ - - - - - - - - - - - - - - - - - - - - - - - - - + + false + $(MSBuildThisFileDirectory)..\SourceGenerators\Uno.UI.Tasks\bin\$(Configuration)_Shadow diff --git a/src/Uno.UI.FluentTheme/FluentMerge.targets b/src/Uno.UI.FluentTheme/FluentMerge.targets index 42dd85a9a7ed..f19df9dcf3f5 100644 --- a/src/Uno.UI.FluentTheme/FluentMerge.targets +++ b/src/Uno.UI.FluentTheme/FluentMerge.targets @@ -1,37 +1,15 @@  - $(MSBuildThisFileDirectory)Resources\**\*.xaml + $(MSBuildThisFileDirectory)Resources\**\*.xaml - - - - - - - - - - - - - - - - - - - - + - - - - - - + + false + $(MSBuildThisFileDirectory)..\SourceGenerators\Uno.UI.Tasks\bin\$(Configuration)_Shadow diff --git a/src/Uno.UI.Maps/Uno.UI.Maps.csproj b/src/Uno.UI.Maps/Uno.UI.Maps.csproj index 8a975777b046..41e8ad820ead 100644 --- a/src/Uno.UI.Maps/Uno.UI.Maps.csproj +++ b/src/Uno.UI.Maps/Uno.UI.Maps.csproj @@ -90,8 +90,11 @@ - + + + false + diff --git a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Skia.csproj b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Skia.csproj index 29e13dbf51e8..bed92185478b 100644 --- a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Skia.csproj +++ b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Skia.csproj @@ -77,14 +77,6 @@ - - - - - - - - diff --git a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Wasm.csproj b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Wasm.csproj index a2534959fc76..4a8d952be2a7 100644 --- a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Wasm.csproj +++ b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Wasm.csproj @@ -93,12 +93,4 @@ - - - - - - - - diff --git a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.csproj b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.csproj index 110e2df6ca77..bfe233f5807a 100644 --- a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.csproj +++ b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.csproj @@ -86,15 +86,9 @@ - - - - - - - - - + + $(MSBuildThisFileDirectory)MUX\Microsoft_UI_XAML_Controls\**\*.xaml + diff --git a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj index 926c30678828..0877c318692e 100644 --- a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj +++ b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj @@ -52,11 +52,6 @@ - - - - - diff --git a/src/Uno.UI.Tests.ViewLibrary/Uno.UI.Tests.ViewLibrary.csproj b/src/Uno.UI.Tests.ViewLibrary/Uno.UI.Tests.ViewLibrary.csproj index b5e6d3461f12..027a2ca8714d 100644 --- a/src/Uno.UI.Tests.ViewLibrary/Uno.UI.Tests.ViewLibrary.csproj +++ b/src/Uno.UI.Tests.ViewLibrary/Uno.UI.Tests.ViewLibrary.csproj @@ -51,11 +51,6 @@ - - - - - diff --git a/src/Uno.UI.Tests/Uno.UI.Tests.csproj b/src/Uno.UI.Tests/Uno.UI.Tests.csproj index 406ba5882c16..ea74087f7bb3 100644 --- a/src/Uno.UI.Tests/Uno.UI.Tests.csproj +++ b/src/Uno.UI.Tests/Uno.UI.Tests.csproj @@ -64,12 +64,10 @@ Resources\%(RecursiveDir)%(FileName)%(Extension) - - - + false $(MSBuildThisFileDirectory)..\SourceGenerators\Uno.UI.Tasks\bin\$(Configuration)_Shadow true @@ -93,18 +91,7 @@ - - - - - - - - - - - - + diff --git a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Reference.csproj b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Reference.csproj index e6cc1cb1bd3d..da636903b6d9 100644 --- a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Reference.csproj +++ b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Reference.csproj @@ -54,11 +54,6 @@ - - - - - diff --git a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Skia.csproj b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Skia.csproj index 697138a7df14..40cb26d2ae2c 100644 --- a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Skia.csproj +++ b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Skia.csproj @@ -52,11 +52,6 @@ - - - - - diff --git a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Wasm.csproj b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Wasm.csproj index 81d207d7f876..cdb7001e83b5 100644 --- a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Wasm.csproj +++ b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.Wasm.csproj @@ -46,11 +46,6 @@ - - - - - diff --git a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.csproj b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.csproj index 4831ac957350..52535b7e959a 100644 --- a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.csproj +++ b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.csproj @@ -93,18 +93,9 @@ - - - - - - - - - - - - + + false + diff --git a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.netcoremobile.csproj b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.netcoremobile.csproj index b4331a904510..d45d5a69efd1 100644 --- a/src/Uno.UI.Toolkit/Uno.UI.Toolkit.netcoremobile.csproj +++ b/src/Uno.UI.Toolkit/Uno.UI.Toolkit.netcoremobile.csproj @@ -62,11 +62,6 @@ - - - - - $(AssemblyName).xml diff --git a/src/Uno.UI/Uno.UI.Reference.csproj b/src/Uno.UI/Uno.UI.Reference.csproj index 48c59c7735dc..a4fce12e7473 100644 --- a/src/Uno.UI/Uno.UI.Reference.csproj +++ b/src/Uno.UI/Uno.UI.Reference.csproj @@ -52,7 +52,7 @@ - + false diff --git a/src/Uno.UI/Uno.UI.Skia.csproj b/src/Uno.UI/Uno.UI.Skia.csproj index 727e98f71a14..2ac4145f3c11 100644 --- a/src/Uno.UI/Uno.UI.Skia.csproj +++ b/src/Uno.UI/Uno.UI.Skia.csproj @@ -66,15 +66,8 @@ - - - - - - - - + $(PlatformItemsBasePath)Themes\WinUI\Resources\**\*.xaml $(MSBuildThisFileDirectory)..\SourceGenerators\Uno.UI.Tasks\bin\$(Configuration)_Shadow _UnoSourceGenerator; $(CompileTypeScriptDependsOn) diff --git a/src/Uno.UI/Uno.UI.Wasm.csproj b/src/Uno.UI/Uno.UI.Wasm.csproj index 1cb75d125217..a3085ae27a2e 100644 --- a/src/Uno.UI/Uno.UI.Wasm.csproj +++ b/src/Uno.UI/Uno.UI.Wasm.csproj @@ -107,15 +107,8 @@ - - - - - - - - + $(PlatformItemsBasePath)Themes\WinUI\Resources\**\*.xaml $(MSBuildThisFileDirectory)..\SourceGenerators\Uno.UI.Tasks\bin\$(Configuration)_Shadow CoreCompile;_UnoSetupTSCompilation; $(CompileTypeScriptDependsOn) diff --git a/src/Uno.UI/Uno.UI.csproj b/src/Uno.UI/Uno.UI.csproj index 3b9cea033360..7934c90d3807 100644 --- a/src/Uno.UI/Uno.UI.csproj +++ b/src/Uno.UI/Uno.UI.csproj @@ -39,6 +39,8 @@ Uno.WinUI + + Themes\WinUI\Resources\**\*.xaml @@ -49,30 +51,9 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + false + diff --git a/src/Uno.UI/Uno.UI.netcoremobile.csproj b/src/Uno.UI/Uno.UI.netcoremobile.csproj index 9067594121d2..81f9df1583d0 100644 --- a/src/Uno.UI/Uno.UI.netcoremobile.csproj +++ b/src/Uno.UI/Uno.UI.netcoremobile.csproj @@ -46,6 +46,8 @@ + + Themes\WinUI\Resources\**\*.xaml @@ -56,30 +58,9 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + false +