Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10 changes string outputs to boolean which can cause patching to fail silently #188

Open
bobh66 opened this issue Aug 28, 2023 · 0 comments
Assignees
Labels
bug Something isn't working needs:triage

Comments

@bobh66
Copy link
Collaborator

bobh66 commented Aug 28, 2023

What happened?

v0.10 added support for nested object outputs, which also has the effect of NOT stringifying the existing outputs, so if an output is a bool that used to get converted to a string, now it stays a bool . This can cause silent failures in patching if the target of the patch is something like metadata.annotations.foo that won't accept a bool.

How can we reproduce it?

Define a Workspace with a boolean output, and observe that prior to v0.10 it is a string in status.atProvider.outputs but after v0.10 it is now a bool.

What environment did it happen in?

  • Provider Version: 0.10
@bobh66 bobh66 added bug Something isn't working needs:triage labels Aug 28, 2023
@bobh66 bobh66 self-assigned this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:triage
Projects
None yet
Development

No branches or pull requests

1 participant