Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape from built-in editor closes uploader window #642

Open
edwh opened this issue Apr 9, 2024 · 1 comment
Open

Escape from built-in editor closes uploader window #642

edwh opened this issue Apr 9, 2024 · 1 comment
Labels

Comments

@edwh
Copy link

edwh commented Apr 9, 2024

Describe the bug

The escape key closes both the built-in editor and the uploader modals.

To Reproduce

  1. Upload a file, and you see the list of uploaded files.
  2. Click the edit icon to edit an image.
  3. Hit the Escape key.

This seems to close both the editor and the uploader modals.

Expected behavior

I think it should close just the editor modal and leave you on the uploader.

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version 123

Smartphone (please complete the following information):

Not tested.

Additional context

@ECecillo
Copy link

ECecillo commented Jul 4, 2024

We faced a similar issue in our project code. We found that a DOM event sent from the Uploadcare library was being handled by the web component and other components listening to the event.

Try using e.preventDefault() for the close event to see if you can isolate the DOM event and prevent it from propagating to the upper component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants