Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new version of chat #12

Open
Odwerneh opened this issue Apr 26, 2021 · 5 comments
Open

Add support for new version of chat #12

Odwerneh opened this issue Apr 26, 2021 · 5 comments

Comments

@Odwerneh
Copy link

Hi,

after a recent update of Google Chat the extension stopped to work (at least on domain mail.google.com). Could you please fix it. My eyes are burning now.

Thank you.

@leomontenegro6
Copy link

I'm also getting the same problem: The addon stopped working after I updated the browser tab today. Looks like the URL changed from http://chat.google.com to http://mail.google.com/chat, and maybe that's why it stopped working.

@leomontenegro6
Copy link

leomontenegro6 commented May 21, 2021

I decided to further investigate this bug by editing this add-on source code and changing the URL. Although some sections of the page had their colors changed, it didn't work as it should: the main window still maintained in white.

I also checked the possibility of achieving this by creating a custom CSS theme and uploading it to sites such as Userstyles, but it didn't work because all elements have random class names that look like they're generated automatically whenever you open Google Chat or the app is updated by Google. That makes it harder to have a CSS theme fully working since it would automatically break the next time Google updates this app.

Going back to fiddling with Google Chat in the browser console, I noticed that besides the fact that the main URL changed to http://mail.google.com/chat, the main window now consists of an <iframe> element that loads data from the older URL, http://chat.google.com. That makes it even harder to achieve the dark theme because of XSS, and I don't know if it's possible to change the theme through JavaScript commands anymore.

Anyway, while we don't have this addon working, I figured out a workaround for this:

If done correctly, the addon "Night Eye" should be applied only in Google Chat and Gmail (we may need both now since they're now connected in a way that GChat now is fully integrated with Gmail), and this addon works through a custom algorithm that tries to apply a dark theme to a site programmatically, without having to invert images or something like that. It's not as beautiful as this add-on, but it's better than drawing back to the default white theme.

Hope it helps.

@leomontenegro6
Copy link

Looks like a new version of this module was released yesterday, and it seems to fix the bugs above. That being the case, I think this issue can be marked as resolved.

@safts
Copy link

safts commented Jun 29, 2021

I don't think it is resolved yet. The theme appears still broken to me.

@leomontenegro6
Copy link

leomontenegro6 commented Jul 1, 2021

It was working since the last addon update at the end of May, but looks like Google Chat was updated again and it broke the addon.

Anyway, at least as a workaround, I confirm that using Night Eye extension still works, as I described above. We can use it temporarily, until the addon is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants