Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support: Sign Transaction Coroutine Variant #21

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Support: Sign Transaction Coroutine Variant #21

merged 1 commit into from
Sep 25, 2019

Conversation

ugoamanoh
Copy link
Contributor

What's Here

  1. Added a suspend variant for UportHDSigner.signTransaction() in the Extensions file
  2. Added comments for existing extension functions

mirceanis
mirceanis approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mirceanis mirceanis merged commit 1d02c04 into develop Sep 25, 2019
@mirceanis mirceanis deleted the support/168749821-courotine-sign-transaction branch March 22, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ugoamanoh @mirceanis