Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelzap] What happened to WithTraceIDField option? #132

Open
mminklet opened this issue Jul 17, 2024 · 2 comments
Open

[otelzap] What happened to WithTraceIDField option? #132

mminklet opened this issue Jul 17, 2024 · 2 comments

Comments

@mminklet
Copy link

We are trying to find a way to force the trace id into the logs so we can more easily join our logs together when the trace isn't sampled (we could generate a new id but we're already using otelzap). This option appears to have been removed in the latest version at some point, and I was wondering why? It is still mentioned in the docs.

I see it was removed here
3f68ff6

With the title convert otelzap to use logs api, but I don't know what that refers to or what the effect is, especially considering the tests were all removed. Is there any further information about this logs api? And specifically, how can I add the trace id to the log without wrapping otelzap and manually retrieving it

@JPFrancoia
Copy link

This option is only useful with backends that don't support OTLP and instead parse log

This is basically the case with GCP. They don't yet have a way to export logs. For traces and metrics yes, but not logs. It's very convenient to just add otelzap.WithTraceIDField(true) and have the logs immediately correlated with traces in GCP.

I had to revert to v0.2.4 to get this feature back. Is there any way we could consider bringing this back?

@beni0888
Copy link

beni0888 commented Oct 9, 2024

Same problem here 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants