We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear/incorrect doc
buttonClass says
Additional classes to put on the buttons Default: ""
But it seems to be replacing thi introjs-button class as well as adding in classes
introjs-button
The docs say, that buttonClass adds additional classes, but doesn't mention that it removes the introjs-button class.
buttonClass
Is it a bug that it is removing it? Or are the docs incorrect?
Locally, I'm just adding introjs-button into buttonClass to deal with this. { buttonClass: 'introjs-button an-additional-class' }
{ buttonClass: 'introjs-button an-additional-class' }
but thought it would be worth mentioning it.
It could be related to this issue #1700
But putting { buttonClass: 'an-additional-class' } seems to be replacing the base button class
{ buttonClass: 'an-additional-class' }
<a role="button" tabindex="0" class="an-additional-class introjs-nextbutton">Next</a> compared to without buttonClass set
<a role="button" tabindex="0" class="an-additional-class introjs-nextbutton">Next</a>
<a role="button" tabindex="0" class="introjs-button introjs-nextbutton">Next</a>
use {buttonClass: 'an-other-class'} in introjs options object
{buttonClass: 'an-other-class'}
Brave browser Version 1.69.168 Chromium: 128.0.6613.138 (Official Build) (64-bit) Using lit-html
Thanks for running this codebase and the amazing product that it is. Happy to run a PR once I know whether the code or the docs are correct
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
Unclear/incorrect doc
buttonClass says
Additional classes to put on the buttons
Default: ""
But it seems to be replacing thi
introjs-button
class as well as adding in classesExpected Behavior
The docs say, that
buttonClass
adds additional classes, but doesn't mention that it removes the introjs-button class.Is it a bug that it is removing it? Or are the docs incorrect?
Locally, I'm just adding introjs-button into buttonClass to deal with this.
{ buttonClass: 'introjs-button an-additional-class' }
but thought it would be worth mentioning it.
It could be related to this issue #1700
Actual Behavior
But putting
{ buttonClass: 'an-additional-class' }
seems to be replacing the base button class
<a role="button" tabindex="0" class="an-additional-class introjs-nextbutton">Next</a>
compared to without buttonClass set
<a role="button" tabindex="0" class="introjs-button introjs-nextbutton">Next</a>
Example (recommended)
use
{buttonClass: 'an-other-class'}
in introjs options objectEnvironment (optional)
Brave browser Version 1.69.168 Chromium: 128.0.6613.138 (Official Build) (64-bit)
Using lit-html
Thanks
Thanks for running this codebase and the amazing product that it is.
Happy to run a PR once I know whether the code or the docs are correct
The text was updated successfully, but these errors were encountered: